feat: unify smartui-storybook into smartui-cli (built-in storybook command + TUI) - #527

…ent, log-symbols)

Gradient figlet banner + launch config box + end-of-run summary box (dashboard
link, screenshot/approval/change counts) around the storybook command. Summary
deferred to process 'beforeExit' so it lands after the engine's polling. Verified
with a live baseline build (11 stories -> 33 screenshots) on SmartUI cloud.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CwQRZwr64F9fLQAW4V1bWy

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CwQRZwr64F9fLQAW4V1bWy

Two bugs that broke the URL-mode capture path (surfaced by live URL testing,
confirmed by @sushobhit-lt review on PR #1):

- storybook.ts: merge root global flags via optsWithGlobals() so `--config`
  actually reaches the engine (local -c/--config collided with the global one),
  letting validateConfig normalize viewports->resolutions.
- dom.cjs: declare `dom`/`clone`/`element` with const — they were implicit
  globals that throw ReferenceError once bundled into strict mode (same class
  as the earlier res/filename/githubURL fixes; these three were missed).
- storybook.cjs: guard the URL-mode resolutions loop with a viewports fallback
  so `smartui storybook <url>` with no -c flag doesn't crash on the default
  config (per review).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CwQRZwr64F9fLQAW4V1bWy

…TE-24909)

URL mode fetched stories.json only. Storybook 8 dropped that file and serves
index.json instead, so the request 404s, discovery reports "Cannot fetch
stories" and the run ends with 0 screenshots. DIR mode already read either file.

Try index.json first and fall back to stories.json, accepting both payload
shapes (entries for v8, stories for v7) and both title fields (title for v8,
kind for v7). Verified against a real Storybook 8.6 index (17 stories) served
with index.json only and with stories.json only: before the change the first
case failed with 404, after it resolves 17 stories from either file.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017LYhe6ASMZLy7LSuAJ8pqQ

…po (TE-24912, TE-24910)

Two auth-adjacent problems in the vendored engine:

PROJECT_NAME (TE-24912). The engine only accepted a pre-issued PROJECT_TOKEN,
while the rest of the CLI accepts PROJECT_NAME and auto-creates the project.
Resolve PROJECT_NAME through the same /visualui/1.0/token/verify call the core
client uses, then continue on the resulting token, so downstream code is
unchanged.

No git repo (TE-24910). The duplicate-build check keys off branch and commit.
Outside a git repo both are empty, the API rejects the call, and the CLI prints
"Cannot fetch latest build of the project. Error: Request failed with status
code 401", which reads like an auth failure. Skip the check with a message
naming the real cause, matching how the core CLI skips git details when it is
not a git repo.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017LYhe6ASMZLy7LSuAJ8pqQ

…nch failures (TE-24911)

This branch switched the lockfile to pnpm, and pnpm 10 blocks dependency install
scripts by default. puppeteer's postinstall never runs, so its Chromium is never
downloaded and URL mode dies on a WS endpoint timeout that says nothing about the
missing browser.

Declare the packages whose install scripts are required in
pnpm.onlyBuiltDependencies, and wrap puppeteer.launch so a failure names the
likely cause and the command that fixes it.

The lockfile change is the playwright bump that came in from stage.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017LYhe6ASMZLy7LSuAJ8pqQ

… refusing (TE-23033)

config:create and config:create-storybook both default to .smartui.json, so
running the second after the first only produced "SmartUI Storybook config
already exists". The schema already allows one file to carry both a web and a
storybook block, so write the block into the existing file instead. An existing
storybook block is still left alone and reported.

Also give the storybook browsers uniqueItems rule its own message, which the
enum catch-all was swallowing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017LYhe6ASMZLy7LSuAJ8pqQ

…ile (TE-23033)

TE-23033 was fixed in one direction only. `config:create-storybook` merges into an
existing .smartui.json, but running the two generators the other way round still
hit "Error: SmartUI Config already exists" and refused, even though the file held
only a storybook block and the schema explicitly allows one file to carry both.

config:create now adds the missing default keys when the existing file has a
storybook block and no web block, and otherwise refuses exactly as before. Every
default key is copied, not just `web`: the top-level ones (waitForTimeout,
smartIgnore and friends) are part of a web config, and copying only `web` and
`mobile` produced a different file depending on which order the two commands ran
in.

Verified against the built binary: both orders now yield the same key set
(allowedHostnames, enableJavaScript, mobile, showRenderErrors, smartIgnore,
storybook, waitForTimeout, web).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015zE3Pt3jgMUMS3xNuej7dF

…E-24909)

URL-mode discovery tries index.json first and falls back to stories.json, but DIR
mode still preferred the legacy stories.json. When a static directory carries both
(a Storybook 7 build rebuilt as 8 leaves the old file behind) the two modes read
different files and could snapshot different story sets from the same Storybook.

DIR mode now prefers index.json with the same legacy fallback, and accepts either
payload key in either file.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015zE3Pt3jgMUMS3xNuej7dF

… a bare token error

Two misleading-error bugs of the same family as TE-24910, both found running the
negative cases on the default code path.

1. The duplicate-build check ran before the target was validated, and it exits the
   run. So `smartui storybook ./does-not-exist` reported "Build with commit ... on
   branch ... already exists" and told the user to pass --force-rebuild. The
   directory and URL validators were correct all along, they were simply never
   reached unless --force-rebuild happened to skip the check in front of them.
   Target validation now runs first. The checks are read-only and idempotent, so
   storybook() re-running them costs nothing beyond one extra request in URL mode.

   Now on the default path:
     ./does-not-exist  -> No directory found: ./does-not-exist
     empty dir         -> Given directory is not a storybook static directory
     dead URL          -> Connection to storybook not established
   and a valid target still falls through to the duplicate-build check unchanged.

2. /token/verify answers HTTP 200 even when project creation fails, carrying the
   reason in the body. Resolution failure printed only "project token not
   received", which reads like a credentials problem. It now prints the server's
   own message, e.g. "Failed to create project: project creation failed with
   status 502 Bad Gateway", which is what was actually happening.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015zE3Pt3jgMUMS3xNuej7dF

…surface

Closes the two engineering follow-ups left open on TE-21062.

Tests. The repository had no test framework at all, so this adds vitest and 64
tests over the parts of this branch that actually broke in QA:

  - storybook config schema, 41 cases including the negative ones (browsers,
    viewport bounds and the 5-viewport cap, waitForTimeout bounds, backgroundTheme,
    chunkSize, the customViewports styles-XOR-waitForTimeout and
    stories-XOR-exclude rules, unknown keys at both levels), plus a guard on
    snapshot ignoreColors so the TE-24908 stale-base failure cannot come back
    unnoticed
  - story discovery, covering index.json, the legacy stories.json fallback, an
    empty index.json falling through rather than yielding a zero-story run, docs
    filtering for both Storybook generations, and the DIR/URL index preference
  - the config generators in both orders

The suite caught a real defect in the config:create fix while it was being
written: copying only `web` and `mobile` made the output depend on which order the
two generators ran in.

@ts-nocheck. src/commander/storybook.ts carried it because the vendored .cjs
imports had no types. It now has hand-written declarations
(src/storybookVendor/index.d.cts, src/lib/tui.d.cts) that describe the engine and
TUI surfaces without touching the vendored JavaScript, which stays a faithful
relocation on purpose.

The file typechecks clean under strict plus noUncheckedIndexedAccess. Two latent
issues surfaced while typing it: kv() drops empty values, so indexing [0] after it
can be undefined, and the catch bound a bare any.

Typecheck scope. `tsc --noEmit` reports 251 pre-existing errors across files this
branch never touches, and the committed tsconfig cannot even be used directly
(module CommonJS with moduleResolution NodeNext is rejected). tsup strips types
without checking them, so this has never been caught. Rather than boil that ocean,
tsconfig.storybook.json checks just this branch's surface, wired up as
`pnpm run typecheck:storybook`.

fetchStoryIndex is exported so the TE-24909 fix can be covered directly.

  pnpm test                  -> 64 passed
  pnpm run typecheck:storybook -> 0 errors

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015zE3Pt3jgMUMS3xNuej7dF